setupad Bid Adapter: initial commit #11008

pashaGhub · 2024-01-30T15:45:22Z

Type of change

New bidder adapter

Description of change

created new setupadBidAdapter

contact email
it@setupad.com
test parameters for validating bids:

{
    bidder: 'setupad',
    params: {
      placement_id: '3916',
      account_id: 'test',
   },
},

Other information

SETUPAD prebid.github.io PR: prebid/prebid.github.io#5114

* add setupadBidAdapter * update setupadBidAdapter * update metrics collection * update analytics collection * update getUserSyncs * add setupadAnalyticsAdapter.js * test setupadAnalyticsAdapter * remove test: 1 * add GVLID && bug fixes && test updates * remove setupadAnalyticsAdapter * add userID module handling * add GVLID && bug fixes && test updates * remove setupadAnalyticsAdapter * add userID module handling * clean up && seat bugfix * clean up logs * add userID module handling * update md && clean up * Send setupad only on bidRequested * Fix bidResponse and bidWon responses * Improve bidResponse and bidWon logic * Revert changes to specific files * Remove test parameter * Fix multiple bidResponse and bidTimeout calls to getPixelUrl * eslint errors fixes(brackets added) * Add extra checks for events * Fix BIDDER_CODE const * update reporting endpoint * update setupadBidAdapter_spec.js REPORT_ENDPOINT * update readme * Revert "Merge branch 'prebid:master' into setupad-adapter" This reverts commit 1c14dbe, reversing changes made to 7fe9ea5. * Revert "Revert "Merge branch 'prebid:master' into setupad-adapter"" This reverts commit a34e3e4. * # This is a combination of 20 commits. # This is the 1st commit message: add setupadBidAdapter # This is the commit message #2: update setupadBidAdapter # This is the commit message prebid#3: update metrics collection # This is the commit message prebid#4: update analytics collection # This is the commit message prebid#5: update getUserSyncs # This is the commit message prebid#6: add setupadAnalyticsAdapter.js # This is the commit message prebid#7: test setupadAnalyticsAdapter # This is the commit message prebid#8: remove test: 1 # This is the commit message prebid#9: add GVLID && bug fixes && test updates # This is the commit message prebid#10: remove setupadAnalyticsAdapter # This is the commit message prebid#11: add userID module handling # This is the commit message prebid#12: clean up && seat bugfix # This is the commit message prebid#13: add userID module handling # This is the commit message prebid#14: add GVLID && bug fixes && test updates # This is the commit message prebid#15: remove setupadAnalyticsAdapter # This is the commit message prebid#16: add userID module handling # This is the commit message prebid#17: clean up logs # This is the commit message prebid#18: update md && clean up # This is the commit message prebid#19: Send setupad only on bidRequested # This is the commit message prebid#20: Fix bidResponse and bidWon responses * # This is a combination of 22 commits.tree 8abae7e6dffc9a21ad11770713ba485fc610028a parent cecfce3 author pavel <pavel@setupad.com> 1706627437 +0200 committer pavel <pavel@setupad.com> 1706627437 +0200 gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5EW0ACgkQFABtd4pC s/CK3w//WWJSFUlycnnNKTV2XfdcBjooOeZZvjpXVthwr09CCC4uO//kw4bPluhn f5fcVFdXzrY1AZ6ch8Wo3msX/Pkso014jIGd5aIWcHpNYFtffACwH/40Y8AcJNZd bsOZxVK0awPTz/RihC5eY+0J3cP+iFWP/FlYJoHEQIBXq/Eg6mWoAhxwpL/JvxbY QbLFWsRn2ckQ6ftOZgm3/jh8VLaG1zWbWImlWEs5Zel+CorJBTniTj58VbApelYD TFMgbSR2I4NGVaqNIrHePnSMsDATxalQ2nZPwY6raKCHWIbvoUPIn/OpDMMbKgC7 nCwounNmObxFVoj3xusAZppzHpKPasY8xKWb2Kr7zfhZArsOMC6B7fYqQNK0cWG3 8RR/10oheJD9M2kRlfLiqnRv7ExY08SQ/ZMo9LA8BeRUGBXhh6++8FKhKIHvX1gL k1R5W6c+NNWP+PDFsmrFpMn+LpYdl84I7yfYK5dHuw80od7f1wuAVYpswi6Cziy9 /KY6/rfENvUrGTmWSh5GdDBel89ACCfFkasIKB92xhzKTfjzF/DXkc8XQZOMbt1j CsILgWMNfLPMo4Dlgdx/tYCSLLBNEtZ1/hhUcFQ3+0TzLf0GtMkvMnlBnDinqe1n 1P30fQ2I5W5NJKDPrCOnRymI6QOAPFXtMF11R81mbB9H8asft/E= =oJtZ -----END PGP SIGNATURE----- bugfixes # This is the commit message prebid#22: Remove test parameter * # This is a combination of 26 commits. parent cecfce3 author pavel <pavel@setupad.com> 1706627437 +0200 committer pavel <pavel@setupad.com> 1706627437 +0200 gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5EW0ACgkQFABtd4pC s/CK3w//WWJSFUlycnnNKTV2XfdcBjooOeZZvjpXVthwr09CCC4uO//kw4bPluhn f5fcVFdXzrY1AZ6ch8Wo3msX/Pkso014jIGd5aIWcHpNYFtffACwH/40Y8AcJNZd bsOZxVK0awPTz/RihC5eY+0J3cP+iFWP/FlYJoHEQIBXq/Eg6mWoAhxwpL/JvxbY QbLFWsRn2ckQ6ftOZgm3/jh8VLaG1zWbWImlWEs5Zel+CorJBTniTj58VbApelYD TFMgbSR2I4NGVaqNIrHePnSMsDATxalQ2nZPwY6raKCHWIbvoUPIn/OpDMMbKgC7 nCwounNmObxFVoj3xusAZppzHpKPasY8xKWb2Kr7zfhZArsOMC6B7fYqQNK0cWG3 8RR/10oheJD9M2kRlfLiqnRv7ExY08SQ/ZMo9LA8BeRUGBXhh6++8FKhKIHvX1gL k1R5W6c+NNWP+PDFsmrFpMn+LpYdl84I7yfYK5dHuw80od7f1wuAVYpswi6Cziy9 /KY6/rfENvUrGTmWSh5GdDBel89ACCfFkasIKB92xhzKTfjzF/DXkc8XQZOMbt1j CsILgWMNfLPMo4Dlgdx/tYCSLLBNEtZ1/hhUcFQ3+0TzLf0GtMkvMnlBnDinqe1n 1P30fQ2I5W5NJKDPrCOnRymI6QOAPFXtMF11R81mbB9H8asft/E= =oJtZ -----END PGP SIGNATURE----- bugfixes # This is the commit message prebid#22: Remove test parameter # This is the commit message prebid#23: Fix multiple bidResponse and bidTimeout calls to getPixelUrl # This is the commit message prebid#25: eslint errors fixes(brackets added) # This is the commit message prebid#26: Add extra checks for events * parent 75178b9 author pavel <pavel@setupad.com> 1706627694 +0200 committer pavel <pavel@setupad.com> 1706627694 +0200 gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5Em4ACgkQFABtd4pC s/BBUQ/+NXyHoxPM185YJLG9M1ySC/5vTT9W5mfwQ93cVDLCeuGnpsnmi4S21NuQ b7gSeokFjwztvVOUmh/xqMp4lTsvL53TUd00b1k4KGVSqgcF00Foit5g8fOGLYsI DAoqphYV6MWjpAun+II+ELY8QUkHR1cjTc7PEGtmf+8RnptGVdyJ6C9Ab8u9TQTY Apj5Srhfo3Tl8S+WScOxwwB/uqEJR4fhIrJyzFzdLDEb2olSPyrQUs87vQXlhEnK buPEg2F5JsRH6sw11Xp3TFNSZGxNnBSlTh9dixou5md4yRCv5a2TMef667N0BVDp lGgc7mCrRKXyqzphmmeHudiscEGFjtUPObXoHutSVw22wdARFCTpNFKBLLFn4v8o Zv1OvFdNprvHsoeW0HVlZdU7OKnDTRrko6DHk2AahxojjvAFEWuDsGYZNjhdQwRR lK1zm+SFQnKI0Eojd+f84fvKod9geGs640jyH/x5R4eYm4yjZb8SkRtd3cca88wS OuGq9LIkbU428b46l7VnDwudldTXPUU8eKfUtFRjdGtIWH9I3tK6TsRoCfTcXkv0 smxYiiU1XHjAkkPFWQWEeFdfZ071snFKVWouU0AoKiq+PdRoS8+3AJqIQUjlA2sH AybnSkv9KxY/Rs1bnvMubsQm1GF66qVrbxBU6FILBv1JZYwj4yA= =Gbog -----END PGP SIGNATURE----- bugfixes update setupadBidAdapter_spec.js REPORT_ENDPOINT update readme Revert "Merge branch 'prebid:master' into setupad-adapter" This reverts commit 1c14dbe, reversing changes made to 7fe9ea5. Revert "Revert "Merge branch 'prebid:master' into setupad-adapter"" This reverts commit a34e3e4. * change double quote to single quote --------- Co-authored-by: pavel <pavel@setupad.com> Co-authored-by: Elgars Grodnis <elgars@setupad.com>

modules/setupadBidAdapter.js

patmmccann · 2024-01-30T20:56:01Z

modules/setupadBidAdapter.js

+
+    initEvents() {
+      this.disabledSending =
+        !!config.getBidderConfig()?.setupad?.disabledSendingStatisticData;


make sure you document this

sure, in our docs we explain how to disable sending statistics data

remove getAdEl, spelling correction

robertrmartinez · 2024-02-07T01:46:41Z

I am not sure all of this event handling "sendingDataStatistic" should be done in a bid adapter.

This is what Analytics Adapters are for.

As far as I can tell there is no precedence for this and I do not think we should start now unless a compelling reason is given.

The right thing to do is to have a setupadBidAdapter and a setupadAnalyticsAdapter

Will ask for feedback from the Prebid Org team

@patmmccann @dgirardi

pashaGhub · 2024-02-07T10:55:45Z

I am not sure all of this event handling "sendingDataStatistic" should be done in a bid adapter.

This is what Analytics Adapters are for.

As far as I can tell there is no precedence for this and I do not think we should start now unless a compelling reason is given.

The right thing to do is to have a setupadBidAdapter and a setupadAnalyticsAdapter

Will ask for feedback from the Prebid Org team

@patmmccann @dgirardi

actually, we have precedence already: nextMilleniumBidAdapter is sending analytics from their bid adapter.

ChrisHuie · 2024-02-07T11:18:30Z

I am not sure all of this event handling "sendingDataStatistic" should be done in a bid adapter.
This is what Analytics Adapters are for.
As far as I can tell there is no precedence for this and I do not think we should start now unless a compelling reason is given.
The right thing to do is to have a setupadBidAdapter and a setupadAnalyticsAdapter
Will ask for feedback from the Prebid Org team
@patmmccann @dgirardi

actually, we have precedence already: nextMilleniumBidAdapter is sending analytics from their bid adapter.

Yeah. This is more a question of the behavior we want going forward. We would make nextMillenium update their adapter as well if the committee decides this isn't desired behavior.

pashaGhub · 2024-02-07T13:08:25Z

I am not sure all of this event handling "sendingDataStatistic" should be done in a bid adapter.
This is what Analytics Adapters are for.
As far as I can tell there is no precedence for this and I do not think we should start now unless a compelling reason is given.
The right thing to do is to have a setupadBidAdapter and a setupadAnalyticsAdapter
Will ask for feedback from the Prebid Org team
@patmmccann @dgirardi

actually, we have precedence already: nextMilleniumBidAdapter is sending analytics from their bid adapter.

Yeah. This is more a question of the behavior we want going forward. We would make nextMillenium update their adapter as well if the committee decides this isn't desired behavior.

copy that. Waiting for response

robertrmartinez · 2024-02-07T15:03:29Z

My apologies, when I did a search it did not come up for any other bid adapters using the events system.

Here is a refined search

I still do not agree with this and think we should not allow this in Bid Adapters as event handlers are blocking as far as I remember.

If we do allow it - it should default as off in my opinion.

Will talk with the team and get back to you. Thanks for understanding!

dimention · 2024-02-09T08:21:40Z

@robertrmartinez @ChrisHuie both Holid and NextMillenium (and us) are using Prebid Server for the backend of these adapters. The purpose of the event handlers is to avoid having to insert tracking pixels into the creative codes and make other corrections in the Prebid Server code, as it doesn't support it out-of-the-box.

robertrmartinez · 2024-02-14T17:16:08Z

Hey @pashaGhub and @dimention

After discussing with the Prebid team we have deemed that bid adapters are not allowed to import the events system any longer.

It was kind of a loop hole in the rules that we are officially closing.

Here are two issues opened up:

#11071
and
#11072

Bid Adapters can use the existing event handlers provided in the specs if needed and send signals using those.

But importing the general events system is not allowed.

onBidWon event handling moved from custom to native onBidWon method

pashaGhub · 2024-02-28T14:21:36Z

Hey @pashaGhub and @dimention

After discussing with the Prebid team we have deemed that bid adapters are not allowed to import the events system any longer.

It was kind of a loop hole in the rules that we are officially closing.

Here are two issues opened up:

#11071 and #11072

Bid Adapters can use the existing event handlers provided in the specs if needed and send signals using those.

But importing the general events system is not allowed.

Hey @robertrmartinez, @ChrisHuie, @patmmccann
events system removed and functionality moved to the native onBidWon adapter method.

pashaGhub · 2024-03-11T06:14:15Z

Hey @robertrmartinez, @ChrisHuie, @patmmccann
any updates?

robertrmartinez · 2024-03-11T18:45:06Z

Hey @pashaGhub sorry for the delay here.

Will review this today.

robertrmartinez

Couple minor things pointed out.

Also, your endpoint request and response seems to be in standard ORTB, you can always use the ORTB Converter from prebid libraries to generate standard ORTB which may make a more simple adapter so you do not have to do those translations yourself.

https://github.com/prebid/Prebid.js/tree/master/libraries/ortbConverter

Example implementations:
https://github.com/prebid/Prebid.js/blob/master/modules/openxBidAdapter.js
https://github.com/prebid/Prebid.js/blob/master/modules/kimberliteBidAdapter.js

Not required just a suggestion!

robertrmartinez · 2024-03-12T01:50:20Z

modules/setupadBidAdapter.js

+    const requests = [];
+    window.nmmRefreshCounts = window.nmmRefreshCounts || {};
+    _each(validBidRequests, function (bid) {
+      window.nmmRefreshCounts[bid.adUnitCode] = window.nmmRefreshCounts[bid.adUnitCode] || 0;


Did you want to increment this counter? Or is this something your other code on page does?

Because this looks like it just sets a map of adUnits where all values will be zero?

robertrmartinez · 2024-03-12T01:54:21Z

modules/setupadBidAdapter.js

+
+        // Set all bidders obj for later use in getPixelUrl()
+        biddersCpms[res.seat] = bidResponse.cpm;
+        biddersCreativeIds[res.seat] = bidResponse.creativeId;


these maps are supposed to just take the latest entry and overwrite each time?

For example if several auctions are run and you get a seat that responds more than once on a page load, it will overwrite the seat's bidderCpms and biddersCreativeIds stuff.

robertrmartinez · 2024-03-12T01:55:31Z

modules/setupadBidAdapter.js

+      }
+  }
+
+  return { ad, adUrl, vastXml, vastUrl };


vastXml, vastUrl are not used ever (and your adapter only supports banner for now it seems so you can remove these

robertrmartinez · 2024-03-12T02:15:10Z

modules/setupadBidAdapter.js

+}
+
+function getSiteObj() {
+  const refInfo = (getRefererInfo && getRefererInfo()) || {};


You probably do not need to import getRefererInfo as on the bidderRequest object there should be the referer info you are looking for.

Example:

So maybe you can just pass bidderRequest.refererInfo into getSiteObj as refInfo in the func declaration and get rid of the import?

robertrmartinez · 2024-03-12T02:16:27Z

modules/setupadBidAdapter.js

+      window.document.documentElement.clientHeight ||
+      window.document.body.clientHeight ||
+      0,
+  };


Both these device and site objects are probably available in the ortb object of your bidderRequest

Examples:

So maybe can simplify the logic to pick from there.

pashaGhub · 2024-03-16T14:29:52Z

Couple minor things pointed out.

Also, your endpoint request and response seems to be in standard ORTB, you can always use the ORTB Converter from prebid libraries to generate standard ORTB which may make a more simple adapter so you do not have to do those translations yourself.

https://github.com/prebid/Prebid.js/tree/master/libraries/ortbConverter

Example implementations: https://github.com/prebid/Prebid.js/blob/master/modules/openxBidAdapter.js https://github.com/prebid/Prebid.js/blob/master/modules/kimberliteBidAdapter.js

Not required just a suggestion!

Thanks a lot for the information!
We are staying with the current solution at the moment, however, we will definitely consider updating our adapter in the future.

* create setupadBidAdapter * add setupadBidAdapter * update setupadBidAdapter * update metrics collection * update analytics collection * update getUserSyncs * add setupadAnalyticsAdapter.js * test setupadAnalyticsAdapter * remove test: 1 * add GVLID && bug fixes && test updates * remove setupadAnalyticsAdapter * add userID module handling * add GVLID && bug fixes && test updates * remove setupadAnalyticsAdapter * add userID module handling * clean up && seat bugfix * clean up logs * add userID module handling * update md && clean up * Send setupad only on bidRequested * Fix bidResponse and bidWon responses * Improve bidResponse and bidWon logic * Revert changes to specific files * Remove test parameter * Fix multiple bidResponse and bidTimeout calls to getPixelUrl * eslint errors fixes(brackets added) * Add extra checks for events * Fix BIDDER_CODE const * update reporting endpoint * update setupadBidAdapter_spec.js REPORT_ENDPOINT * update readme * Revert "Merge branch 'prebid:master' into setupad-adapter" This reverts commit 1c14dbe, reversing changes made to 7fe9ea5. * Revert "Revert "Merge branch 'prebid:master' into setupad-adapter"" This reverts commit a34e3e4. * # This is a combination of 20 commits. # This is the 1st commit message: add setupadBidAdapter # This is the commit message #2: update setupadBidAdapter # This is the commit message #3: update metrics collection # This is the commit message #4: update analytics collection # This is the commit message #5: update getUserSyncs # This is the commit message #6: add setupadAnalyticsAdapter.js # This is the commit message #7: test setupadAnalyticsAdapter # This is the commit message #8: remove test: 1 # This is the commit message #9: add GVLID && bug fixes && test updates # This is the commit message #10: remove setupadAnalyticsAdapter # This is the commit message #11: add userID module handling # This is the commit message #12: clean up && seat bugfix # This is the commit message #13: add userID module handling # This is the commit message #14: add GVLID && bug fixes && test updates # This is the commit message #15: remove setupadAnalyticsAdapter # This is the commit message #16: add userID module handling # This is the commit message #17: clean up logs # This is the commit message #18: update md && clean up # This is the commit message #19: Send setupad only on bidRequested # This is the commit message #20: Fix bidResponse and bidWon responses * # This is a combination of 22 commits.tree 8abae7e6dffc9a21ad11770713ba485fc610028a parent cecfce3 author pavel <pavel@setupad.com> 1706627437 +0200 committer pavel <pavel@setupad.com> 1706627437 +0200 gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5EW0ACgkQFABtd4pC s/CK3w//WWJSFUlycnnNKTV2XfdcBjooOeZZvjpXVthwr09CCC4uO//kw4bPluhn f5fcVFdXzrY1AZ6ch8Wo3msX/Pkso014jIGd5aIWcHpNYFtffACwH/40Y8AcJNZd bsOZxVK0awPTz/RihC5eY+0J3cP+iFWP/FlYJoHEQIBXq/Eg6mWoAhxwpL/JvxbY QbLFWsRn2ckQ6ftOZgm3/jh8VLaG1zWbWImlWEs5Zel+CorJBTniTj58VbApelYD TFMgbSR2I4NGVaqNIrHePnSMsDATxalQ2nZPwY6raKCHWIbvoUPIn/OpDMMbKgC7 nCwounNmObxFVoj3xusAZppzHpKPasY8xKWb2Kr7zfhZArsOMC6B7fYqQNK0cWG3 8RR/10oheJD9M2kRlfLiqnRv7ExY08SQ/ZMo9LA8BeRUGBXhh6++8FKhKIHvX1gL k1R5W6c+NNWP+PDFsmrFpMn+LpYdl84I7yfYK5dHuw80od7f1wuAVYpswi6Cziy9 /KY6/rfENvUrGTmWSh5GdDBel89ACCfFkasIKB92xhzKTfjzF/DXkc8XQZOMbt1j CsILgWMNfLPMo4Dlgdx/tYCSLLBNEtZ1/hhUcFQ3+0TzLf0GtMkvMnlBnDinqe1n 1P30fQ2I5W5NJKDPrCOnRymI6QOAPFXtMF11R81mbB9H8asft/E= =oJtZ -----END PGP SIGNATURE----- bugfixes # This is the commit message prebid#22: Remove test parameter * # This is a combination of 26 commits. parent cecfce3 author pavel <pavel@setupad.com> 1706627437 +0200 committer pavel <pavel@setupad.com> 1706627437 +0200 gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5EW0ACgkQFABtd4pC s/CK3w//WWJSFUlycnnNKTV2XfdcBjooOeZZvjpXVthwr09CCC4uO//kw4bPluhn f5fcVFdXzrY1AZ6ch8Wo3msX/Pkso014jIGd5aIWcHpNYFtffACwH/40Y8AcJNZd bsOZxVK0awPTz/RihC5eY+0J3cP+iFWP/FlYJoHEQIBXq/Eg6mWoAhxwpL/JvxbY QbLFWsRn2ckQ6ftOZgm3/jh8VLaG1zWbWImlWEs5Zel+CorJBTniTj58VbApelYD TFMgbSR2I4NGVaqNIrHePnSMsDATxalQ2nZPwY6raKCHWIbvoUPIn/OpDMMbKgC7 nCwounNmObxFVoj3xusAZppzHpKPasY8xKWb2Kr7zfhZArsOMC6B7fYqQNK0cWG3 8RR/10oheJD9M2kRlfLiqnRv7ExY08SQ/ZMo9LA8BeRUGBXhh6++8FKhKIHvX1gL k1R5W6c+NNWP+PDFsmrFpMn+LpYdl84I7yfYK5dHuw80od7f1wuAVYpswi6Cziy9 /KY6/rfENvUrGTmWSh5GdDBel89ACCfFkasIKB92xhzKTfjzF/DXkc8XQZOMbt1j CsILgWMNfLPMo4Dlgdx/tYCSLLBNEtZ1/hhUcFQ3+0TzLf0GtMkvMnlBnDinqe1n 1P30fQ2I5W5NJKDPrCOnRymI6QOAPFXtMF11R81mbB9H8asft/E= =oJtZ -----END PGP SIGNATURE----- bugfixes # This is the commit message prebid#22: Remove test parameter # This is the commit message prebid#23: Fix multiple bidResponse and bidTimeout calls to getPixelUrl # This is the commit message prebid#25: eslint errors fixes(brackets added) # This is the commit message prebid#26: Add extra checks for events * parent 75178b9 author pavel <pavel@setupad.com> 1706627694 +0200 committer pavel <pavel@setupad.com> 1706627694 +0200 gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5Em4ACgkQFABtd4pC s/BBUQ/+NXyHoxPM185YJLG9M1ySC/5vTT9W5mfwQ93cVDLCeuGnpsnmi4S21NuQ b7gSeokFjwztvVOUmh/xqMp4lTsvL53TUd00b1k4KGVSqgcF00Foit5g8fOGLYsI DAoqphYV6MWjpAun+II+ELY8QUkHR1cjTc7PEGtmf+8RnptGVdyJ6C9Ab8u9TQTY Apj5Srhfo3Tl8S+WScOxwwB/uqEJR4fhIrJyzFzdLDEb2olSPyrQUs87vQXlhEnK buPEg2F5JsRH6sw11Xp3TFNSZGxNnBSlTh9dixou5md4yRCv5a2TMef667N0BVDp lGgc7mCrRKXyqzphmmeHudiscEGFjtUPObXoHutSVw22wdARFCTpNFKBLLFn4v8o Zv1OvFdNprvHsoeW0HVlZdU7OKnDTRrko6DHk2AahxojjvAFEWuDsGYZNjhdQwRR lK1zm+SFQnKI0Eojd+f84fvKod9geGs640jyH/x5R4eYm4yjZb8SkRtd3cca88wS OuGq9LIkbU428b46l7VnDwudldTXPUU8eKfUtFRjdGtIWH9I3tK6TsRoCfTcXkv0 smxYiiU1XHjAkkPFWQWEeFdfZ071snFKVWouU0AoKiq+PdRoS8+3AJqIQUjlA2sH AybnSkv9KxY/Rs1bnvMubsQm1GF66qVrbxBU6FILBv1JZYwj4yA= =Gbog -----END PGP SIGNATURE----- bugfixes update setupadBidAdapter_spec.js REPORT_ENDPOINT update readme Revert "Merge branch 'prebid:master' into setupad-adapter" This reverts commit 1c14dbe, reversing changes made to 7fe9ea5. Revert "Revert "Merge branch 'prebid:master' into setupad-adapter"" This reverts commit a34e3e4. * change double quote to single quote --------- Co-authored-by: pavel <pavel@setupad.com> Co-authored-by: Elgars Grodnis <elgars@setupad.com> * bugfix setupadBidAdapter remove getAdEl, spelling correction * add onBidWon event onBidWon event handling moved from custom to native onBidWon method * minor bugfixes && remove funk getSiteObj && getDeviceObj --------- Co-authored-by: pavel <pavel@setupad.com> Co-authored-by: Elgars Grodnis <elgars@setupad.com>

patmmccann reviewed Jan 30, 2024

View reviewed changes

modules/setupadBidAdapter.js Outdated Show resolved Hide resolved

patmmccann reviewed Jan 30, 2024

View reviewed changes

modules/setupadBidAdapter.js Outdated Show resolved Hide resolved

patmmccann reviewed Jan 30, 2024

View reviewed changes

patmmccann changed the title ~~create setupadBidAdapter~~ setupad Bid Adapter: initial commit Jan 30, 2024

bugfix setupadBidAdapter

6cc4b00

remove getAdEl, spelling correction

jsnellbaker requested a review from robertrmartinez February 1, 2024 14:06

jsnellbaker assigned robertrmartinez Feb 1, 2024

jsnellbaker added the feature label Feb 1, 2024

patmmccann added the needs update label Feb 24, 2024

add onBidWon event

b8ac39c

onBidWon event handling moved from custom to native onBidWon method

robertrmartinez requested changes Mar 12, 2024

View reviewed changes

minor bugfixes && remove funk getSiteObj && getDeviceObj

86422f6

robertrmartinez self-requested a review March 19, 2024 17:03

robertrmartinez approved these changes Mar 19, 2024

View reviewed changes

robertrmartinez merged commit 48113b1 into prebid:master Mar 19, 2024
2 checks passed

dimention mentioned this pull request Mar 20, 2024

Setupad prebid/prebid.github.io#5114

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

setupad Bid Adapter: initial commit #11008

setupad Bid Adapter: initial commit #11008

pashaGhub commented Jan 30, 2024

patmmccann Jan 30, 2024

pashaGhub Feb 1, 2024

robertrmartinez commented Feb 7, 2024

pashaGhub commented Feb 7, 2024

ChrisHuie commented Feb 7, 2024

pashaGhub commented Feb 7, 2024

robertrmartinez commented Feb 7, 2024

dimention commented Feb 9, 2024

robertrmartinez commented Feb 14, 2024

pashaGhub commented Feb 28, 2024 •

edited

Loading

pashaGhub commented Mar 11, 2024

robertrmartinez commented Mar 11, 2024

robertrmartinez left a comment

robertrmartinez Mar 12, 2024

robertrmartinez Mar 12, 2024

robertrmartinez Mar 12, 2024

robertrmartinez Mar 12, 2024

robertrmartinez Mar 12, 2024

pashaGhub commented Mar 16, 2024

setupad Bid Adapter: initial commit #11008

setupad Bid Adapter: initial commit #11008

Conversation

pashaGhub commented Jan 30, 2024

Type of change

Description of change

Other information

patmmccann Jan 30, 2024

Choose a reason for hiding this comment

pashaGhub Feb 1, 2024

Choose a reason for hiding this comment

robertrmartinez commented Feb 7, 2024

pashaGhub commented Feb 7, 2024

ChrisHuie commented Feb 7, 2024

pashaGhub commented Feb 7, 2024

robertrmartinez commented Feb 7, 2024

dimention commented Feb 9, 2024

robertrmartinez commented Feb 14, 2024

pashaGhub commented Feb 28, 2024 • edited Loading

pashaGhub commented Mar 11, 2024

robertrmartinez commented Mar 11, 2024

robertrmartinez left a comment

Choose a reason for hiding this comment

robertrmartinez Mar 12, 2024

Choose a reason for hiding this comment

robertrmartinez Mar 12, 2024

Choose a reason for hiding this comment

robertrmartinez Mar 12, 2024

Choose a reason for hiding this comment

robertrmartinez Mar 12, 2024

Choose a reason for hiding this comment

robertrmartinez Mar 12, 2024

Choose a reason for hiding this comment

pashaGhub commented Mar 16, 2024

pashaGhub commented Feb 28, 2024 •

edited

Loading